Make use of patch.multiple to clean up mocks

This commit is contained in:
Eric Torres
2019-04-16 22:49:01 -07:00
parent c410f4c115
commit f55b5ba8af
2 changed files with 80 additions and 81 deletions

View File

@@ -3,11 +3,13 @@
Tests for the rbackup.struct.hierarchy module.
"""
import shutil
import unittest
from unittest.mock import PropertyMock, mock_open, patch
from pathlib import Path
from unittest.mock import DEFAULT, patch
from hypothesis import given
from hypothesis.strategies import from_regex, text
from hypothesis.strategies import from_regex
from rbackup.struct.hierarchy import Hierarchy
@@ -18,40 +20,41 @@ TESTING_MODULE = f"{TESTING_PACKAGE}.hierarchy"
# ========== Tests ==========
class TestHierarchyPaths(unittest.TestCase):
def test_retrieves_correct_metadata_filename(self):
self.assertEqual(Hierarchy("backup").metadata_path.name, ".metadata")
@given(from_regex(r"[\w/._-]+", fullmatch=True))
def test_returns_absolute_path(self, dest):
self.assertTrue(Hierarchy(dest).path.is_absolute())
def test_raises_notimplemented_error(self):
h = Hierarchy("backup")
with self.assertRaises(NotImplementedError):
h.gen_metadata()
class TestHierarchyMetadata(unittest.TestCase):
def setUp(self):
self.patched_json = patch(f"{TESTING_MODULE}.json")
self.patched_path = patch.object(
Hierarchy, "metadata_path", new_callable=PropertyMock, create=True
self.patched_path = patch.multiple(
Path, exists=DEFAULT, mkdir=DEFAULT, symlink_to=DEFAULT, touch=DEFAULT
)
self.mocked_path = self.patched_path.start()
self.mocked_json = self.patched_json.start()
self.mocked_path.return_value.open = mock_open
def test_retrieves_correct_metadata_filename(self):
self.assertEqual(Hierarchy("/tmp/backup").metadata_path.name, ".metadata")
@unittest.skip("Figure out how to mock file objects")
@given(text())
def test_write_metadata(self, data):
h = Hierarchy("backup")
h.write_metadata(data)
read_data = h.read_metadata()
@given(from_regex(r"[\w/._-]+", fullmatch=True))
def test_returns_absolute_path(self, dest):
try:
self.assertTrue(Hierarchy(dest).path.is_absolute())
except PermissionError:
pass
self.assertEqual(data, read_data)
def test_raises_notimplemented_error(self):
h = Hierarchy("/tmp/backup")
with self.assertRaises(NotImplementedError):
h.gen_metadata()
def tearDown(self):
self.patched_json.stop()
self.patched_path.stop()
class TestHierarchyMetadata(unittest.TestCase):
"""Only meant to check that data written is the same data that is read."""
def test_write_metadata(self):
data = ["test", "data"]
h = Hierarchy("/tmp/backup")
h.metadata_path.touch()
h.write_metadata(data)
self.assertEqual(data, h.read_metadata())
shutil.rmtree(h)