etorres/rbackup
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor mock cleanups

Browse Source
This commit is contained in:
Eric Torres 2019-04-16 17:14:27 -07:00
parent 529a3b830d
commit e7a8719dc9
1 changed files with 6 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tests/test_repository.py
View File

@ -15,7 +15,7 @@ from rbackup.struct.snapshot import Snapshot
# ========== Constants ========== # ========== Constants ==========
TESTING_PACKAGE = "rbackup.struct" TESTING_PACKAGE = "rbackup.struct"
REPO_MODULE = f"{TESTING_PACKAGE}.repository" TESTING_MODULE = f"{TESTING_PACKAGE}.repository"
SS_MODULE = f"{TESTING_PACKAGE}.snapshot" SS_MODULE = f"{TESTING_PACKAGE}.snapshot"
VALID_SNAPSHOT_NAME = r"[\w._+-]+[^/]*" VALID_SNAPSHOT_NAME = r"[\w._+-]+[^/]*"
@ -215,31 +215,21 @@ class TestRepositoryCleanup(unittest.TestCase):
""" """
def setUp(self): def setUp(self):
self.patched_path = patch.object( self.patched_path = patch(f"{TESTING_MODULE}.Path")
Repository, "metadata_path", new_callable=PropertyMock
)
self.patched_r_metadata = patch.object(
Repository, "read_metadata", spec_set=list
)
self.patched_w_metadata = patch.object(
Repository, "write_metadata", spec_set=list
)
self.patched_shutil = patch(f"{TESTING_PACKAGE}.repository.shutil")
self.patched_snapshot = patch( self.patched_snapshot = patch(
f"{TESTING_PACKAGE}.repository.Snapshot", spec_set=Snapshot f"{TESTING_PACKAGE}.repository.Snapshot", spec_set=Snapshot
) )
self.mocked_path = self.patched_path.start() self.mocked_path = self.patched_path.start()
self.mocked_r_metadata = self.patched_r_metadata.start()
self.mocked_w_metadata = self.patched_w_metadata.start()
self.mocked_shutil = self.patched_shutil.start() self.mocked_shutil = self.patched_shutil.start()
self.mocked_snapshot = self.patched_snapshot.start() self.mocked_snapshot = self.patched_snapshot.start()
self.mocked_shutil.rmtree.avoids_symlink_attacks = True self.mocked_shutil.rmtree.avoids_symlink_attacks = True
def test_stops_on_non_symlink_resistant(self): @patch(f"{TESTING_PACKAGE}.repository.shutil")
self.mocked_shutil.rmtree.avoids_symlink_attacks = False def test_stops_on_non_symlink_resistant(self, mocked_shutil):
repo = Repository("backup") mocked_shutil.rmtree.avoids_symlink_attacks = False
repo = Repository("/tmp/backup")
repo.cleanup(remove_snapshots=True) repo.cleanup(remove_snapshots=True)
@ -269,7 +259,5 @@ class TestRepositoryCleanup(unittest.TestCase):
def tearDown(self): def tearDown(self):
self.patched_path.stop() self.patched_path.stop()
self.patched_r_metadata.stop()
self.patched_w_metadata.stop()
self.patched_shutil.stop() self.patched_shutil.stop()
self.patched_snapshot.stop() self.patched_snapshot.stop()