etorres/rbackup
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use copies of passed lists in tests

Browse Source
This commit is contained in:
Eric Torres
2019-03-28 12:22:04 -07:00
parent 2c16fe793a
commit a3fca71d21
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
rbackup/tests/test_repository.py
View File

@@ -87,7 +87,7 @@ class TestRepositoryPostCreate(unittest.TestCase):
@given(lists(builds(Snapshot, text()), unique=True)) @given(lists(builds(Snapshot, text()), unique=True))
def test_empty(self, l): def test_empty(self, l):
self.repo_snapshots.return_value = l self.repo_snapshots.return_value = l.copy()
repo = Repository('backup') repo = Repository('backup')
repo.create_snapshot() repo.create_snapshot()
@@ -96,23 +96,21 @@ class TestRepositoryPostCreate(unittest.TestCase):
@given(lists(builds(Snapshot, text()), unique=True)) @given(lists(builds(Snapshot, text()), unique=True))
def test_len(self, l): def test_len(self, l):
self.repo_snapshots.return_value = l self.repo_snapshots.return_value = l.copy()
repo = Repository('backup') repo = Repository('backup')
repo.create_snapshot() repo.create_snapshot()
# Did the repository add the snapshot to its internal list? self.assertEqual(len(repo.snapshots), len(l) + 1)
self.assertEqual(len(repo.snapshots), len(l))
@given(lists(builds(Snapshot, text()), unique=True)) @given(lists(builds(Snapshot, text()), unique=True))
def test_current_snapshot(self, l): def test_current_snapshot(self, l):
self.repo_snapshots.return_value = l self.repo_snapshots.return_value = l.copy()
repo = Repository('backup') repo = Repository('backup')
new_snapshot = repo.create_snapshot() new_snapshot = repo.create_snapshot()
self.assertIs(new_snapshot, l[-1]) self.assertIs(new_snapshot, repo.current_snapshot)
self.assertIs(repo.current_snapshot, l[-1])
self.assertIsInstance(new_snapshot, Snapshot) self.assertIsInstance(new_snapshot, Snapshot)
def tearDown(self): def tearDown(self):