etorres/rbackup
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove type and value checking for PackageManager

Browse Source
This commit is contained in:
Eric Torres 2019-04-10 18:17:52 -07:00
parent 94c70b7b2e
commit 977865b5aa
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
rbackup/package_managers/packagemanager.py
View File

@ -7,7 +7,6 @@ import logging
import subprocess import subprocess
import tarfile import tarfile
from collections.abc import Iterable
from pathlib import Path from pathlib import Path
from tempfile import NamedTemporaryFile from tempfile import NamedTemporaryFile
@ -33,15 +32,6 @@ class PackageManager:
:raises: ValueError if pkglist_cmd is an empty str or an iterable :raises: ValueError if pkglist_cmd is an empty str or an iterable
containing an empty str containing an empty str
""" """
if not isinstance(pkglist_cmd, Iterable) or isinstance(pkglist_cmd, dict):
raise TypeError("pkglist_cmd is the wrong type")
elif not pkglist_cmd:
raise ValueError(f"Package list command is empty: {pkglist_cmd}")
elif any(not isinstance(arg, str) for arg in pkglist_cmd):
raise TypeError(f"{pkglist_cmd} contains a non-str value")
elif any(not bool(arg) for arg in pkglist_cmd):
raise ValueError(f"{pkglist_cmd} contains an empty str value")
self._cachedir = Path(cachedir) self._cachedir = Path(cachedir)
self._db_path = Path(db_path) self._db_path = Path(db_path)
self._pkglist_cmd = pkglist_cmd self._pkglist_cmd = pkglist_cmd