Refactoring of code and update of zsh plugin for fedit script

config/ddusb-exclude.conf

@@ -1,4 +1,3 @@
 # File for excluding block devices from being written to
-# Write one device per line, shell-style globs are accepted i.e. /dev/sda*
+# One rule per line, regular expressions are accepted i.e. /dev/sda[0-9]?
-# Brace expansion is not supported
 # Lines beginning with "#" and ";" are ignored

ddusb.py

@@ -2,7 +2,7 @@
 """Wrapper script for using dd to write to a USB drive."""
 
 import argparse
-import glob
+import os
 import pathlib
 import re
 import subprocess
@@ -11,6 +11,10 @@ import subprocess
 COMMENT_PATTERN = "^[#;]"
 EXCLUDE_FILE = "/etc/helper-scripts/ddusb-exclude.conf"
 
+E_BLOCKDEVICE_ERROR = 1
+E_EXCLUDE_ERROR = 2
+E_DD_ERROR = 3
+
 
 # ========== Functions ==========
 def read_exclude_file(exclude_file):
@@ -33,23 +37,6 @@ def read_exclude_file(exclude_file):
     return lines
 
 
-def expand_globs(*globs):
-    """For each glob given, expand these globs and return a list
-    containing each glob expanded.
-
-    :param globs: patterns to expand
-    :type globs: str
-    :returns: all expanded globs aggregated together
-    :rtype: list
-    """
-    expanded_globs = []
-
-    for line in globs:
-        expanded_globs.extend(glob.glob(line, recursive=True))
-
-    return expanded_globs
-
-
 # ========== Main Script ==========
 parser = argparse.ArgumentParser()
 parser.add_argument("-b", "--bs", default=512, help="block size", metavar="bs")
@@ -59,23 +46,23 @@ args = parser.parse_args()
 
 block_size = args.bs
 input_file = args.input_file
-block_device = args.output_file
+block_path = args.output_file
 
-# Ensure that block_device is really a block device
+# Ensure that block_path is really a block device
-if not pathlib.Path(block_device).is_block_device():
+if not pathlib.Path(block_path).is_block_device():
-    print(f'Error: "{block_device}" is not a block device')
+    print(f'Error: "{block_path}" is not a block device')
-    exit(1)
+    exit(E_BLOCKDEVICE_ERROR)
 
-# Check if block_device is excluded
+# Check if block_path is excluded
 exclude_patterns = read_exclude_file(EXCLUDE_FILE)
-device_blacklist = expand_globs(*exclude_patterns)
 
-if block_device in device_blacklist:
+for pattern in exclude_patterns:
-    print(f'Error: "{block_device}" is blacklisted from running dd')
+    if re.fullmatch(pattern, block_path):
-    exit(2)
+        print(f'Error: "{block_path}" is blacklisted from running dd')
+        exit(E_EXCLUDE_ERROR)
 
 print(f"Input file: {input_file}")
-print(f"Block device: {block_device}")
+print(f"Block device: {block_path}")
 print(f"Block size: {block_size}")
 
 try:
@@ -83,13 +70,13 @@ try:
         [
             "dd",
             f"if={input_file}",
-            f"of={block_device}",
+            f"of={block_path}",
             f"bs={block_size}",
             "status=progress",
         ],
         check=True,
     )
 except subprocess.CalledProcessError:
-    exit(3)
+    exit(E_DD_ERROR)
 else:
-    subprocess.run("sync")
+    os.sync()

fedit.py

@@ -14,27 +14,31 @@ import shutil
 import subprocess
 
 # ========== Constants ==========
-# Paths
+# ----- Paths -----
 BOOT_DIR = "/boot"
 ETC_DIR = "/etc"
 
-# Exit Codes
+# ----- Exit Codes -----
 E_NOEDITORFOUND = 2
 E_NOFILESELECTED = 3
 
-# Commands
+# ----- Commands -----
 FIND_CMD = "/usr/bin/fd"
-FIND_OPTS = ["--hidden", "--print0", "--type", "f", "--no-ignore-vcs"]
+FIND_OPTS = ["--hidden", "--print0", "--type", "f"]
-FZF_CMD = "/usr/bin/fzf"
+EXTRA_FIND_OPTS = {"no_ignore_vcs": "--no-ignore", "no_ignore": "--no-ignore-vcs"}
-FZF_OPTS = ["--read0", "--select-1", "--exit-0", "--print0"]
+
 LOCATE_CMD = "/usr/bin/locate"
 LOCATE_OPTS = ["--all", "--ignore-case", "--null"]
 
+FZF_CMD = "/usr/bin/fzf"
+FZF_OPTS = ["--read0", "--select-1", "--exit-0", "--print0"]
+
+# ----- Misc. -----
 LOCALE = "utf-8"
 
 
 # ========== Functions ==========
-def select_editor(editor_override=None):
+def select_editor(override=None):
     """Return a possible canonical path to an editor.
     Select an editor from one of:
     * -e, --editor
@@ -45,15 +49,15 @@ def select_editor(editor_override=None):
 
     If an editor cannot be resolved, then an Error is raised instead.
 
-    :param editor_override: argument to override an editor
+    :param override: argument to override an editor
     :returns: path to one of these editors
     :rtype: str
     :raises: FileNotFoundError if an editor could not be resolved
     """
     editor = None
 
-    if editor_override is not None:
+    if override is not None:
-        editor = shutil.which(editor_override)
+        editor = shutil.which(override)
     elif "EDITOR" in os.environ:
         editor = shutil.which(os.environ.get("EDITOR"))
     elif shutil.which("vim") is not None:
@@ -69,12 +73,16 @@ def gen_editor_cmd(filename):
     """Generate a command line to run for editing a file based on
     permissions.
 
+    This command does not pass extra options to the editor, hence
+    there are no arguments to pass for options.
+
     :param filename: name of file to edit
     :type filename: str or path-like object
     :returns: command to execute to edit file
     :rtype: list
     """
-    # possible for a race condition to occur here
+    # Possible for a race condition to occur here
+    # What happens if the file or its metadata changes?
     if os.access(filename, os.W_OK):
         return [editor, filename]
     else:
@@ -90,21 +98,24 @@ def run_fzf(files):
     :rtype: str
     """
     selected_file = subprocess.run(
-        [FZF_CMD] + FZF_OPTS, input=files, stdout=subprocess.PIPE
+        [FZF_CMD, *FZF_OPTS], input=files, stdout=subprocess.PIPE
     ).stdout
 
     return selected_file.decode(LOCALE).strip("\x00")
 
 
-def find_files(directory=None):
+def find_files(opts, directory=None):
     """Use a find-based program to locate files, then pass to fzf.
 
+    :param opts: options to pass to the find program
+    :type opts: list of str
     :param directory: directory to search for files
     :type directory: str
     :returns: path of user-selected file
     :rtype: bytes
     """
-    cmd = [FIND_CMD] + FIND_OPTS
+    cmd = [FIND_CMD, *opts]
+
     if directory is not None:
         cmd.extend(["--", ".", directory])
 
@@ -126,51 +137,73 @@ def locate_files(patterns):
 
 
 # ========== Main Script ==========
-parser = argparse.ArgumentParser()
+if __name__ == "__main__":
-parser.add_argument(
+    parser = argparse.ArgumentParser()
-    "-b",
+    parser.add_argument(
-    "--boot",
+        "-b",
-    action="store_const",
+        "--boot",
-    const=BOOT_DIR,
+        action="store_const",
-    dest="dir",
+        const=BOOT_DIR,
-    help="edit a file in /boot",
+        dest="dir",
-)
+        help="edit a file in /boot",
-parser.add_argument(
+    )
-    "-d", "--dir", dest="dir", type=str, help="edit a file in a given directory"
+    parser.add_argument(
-)
+        "-d", "--dir", dest="dir", type=str, help="edit a file in a given directory"
-parser.add_argument(
+    )
-    "-E",
+    parser.add_argument(
-    "--etc",
+        "-E",
-    action="store_const",
+        "--etc",
-    const=ETC_DIR,
+        action="store_const",
-    dest="dir",
+        const=ETC_DIR,
-    help="edit a file in /etc",
+        dest="dir",
-)
+        help="edit a file in /etc",
-parser.add_argument("-e", "--editor", help="use a given editor")
+    )
-parser.add_argument("patterns", type=str, nargs="*", help="patterns to pass to locate")
+    parser.add_argument(
+        "-I",
+        "--no-ignore",
+        action="append_const",
+        const="--no-ignore",
+        dest="extra_find_opts",
+        help="do not respect .(git|fd)ignore files",
+    )
+    parser.add_argument(
+        "-i",
+        "--no-ignore-vcs",
+        action="append_const",
+        const="--no-ignore-vcs",
+        dest="extra_find_opts",
+        help="do not respect .gitignore files",
+    )
+    parser.add_argument("-e", "--editor", help="use a given editor")
+    parser.add_argument(
+        "patterns", type=str, nargs="*", help="patterns to pass to locate"
+    )
 
-args = parser.parse_args()
+    args = parser.parse_args()
 
-final_find_cmd = [FIND_CMD] + FIND_OPTS
+    user_opts = [] if args.extra_find_opts is None else args.extra_find_opts
-editor = ""
+    user_opts.extend(FIND_OPTS)
 
-try:
+    editor = ""
-    editor = select_editor(args.editor)
-except FileNotFoundError as e:
-    print(e)
-    exit(E_NOEDITORFOUND)
 
-# If patterns were passed, use locate
+    try:
-# Otherwise check for -d and use fd
+        editor = select_editor(args.editor)
-if not args.patterns == []:
+    except FileNotFoundError as e:
-    files = locate_files(args.patterns)
+        print(e)
-else:
+        exit(E_NOEDITORFOUND)
-    files = find_files(args.dir)
 
-selected_file = run_fzf(files)
+    # If patterns were passed, use locate
+    # Otherwise check for -d and use fd
+    files = (
+        find_files(user_opts, args.dir)
+        if not args.patterns
+        else locate_files(args.patterns)
+    )
 
-if not selected_file == "":
+    selected_file = run_fzf(files)
-    cmd = gen_editor_cmd(selected_file)
+
-    subprocess.run(cmd)
+    if selected_file != "":
-else:
+        cmd = gen_editor_cmd(selected_file)
-    exit(E_NOFILESELECTED)
+        subprocess.run(cmd)
+    else:
+        exit(E_NOFILESELECTED)

quickdel.py

@@ -0,0 +1,182 @@
+#!/usr/bin/python3
+"""
+quickdel - delete any file matching a query
+
+Dependencies
+============
+* fd
+* python-termcolor
+
+Command-Line Arguments
+======================
+* -d, --directories-only
+* -D, --directory       TODO: implement this
+* -e, --empty-only
+* -E, --extension
+* -f, --files-only
+* -F, --force-directory-delete
+* -i, --no-ignore
+* -I, --no-ignore-vcs
+* -l, --links-only
+"""
+
+import argparse
+import os
+import os.path
+import re
+import shutil
+import subprocess
+
+from termcolor import colored
+
+# ========== Constants ==========
+FD_BIN = "/usr/bin/fd"
+FD_OPTS = ["--hidden"]
+# Matches 'y' or 'yes' only, ignoring case
+USER_RESPONSE_YES = "^[Yy]{1}([Ee]{1}[Ss]{1})?$"
+
+E_NO_RESULTS = 1
+E_USER_RESPONSE_NO = 2
+E_INPUT_INTERRUPTED = 3
+
+
+# ========== Functions ==========
+def color_file(filename):
+    """Return correct color code for filetype of filename.
+
+    Example
+    -------
+    >>> color_file('Test File', 'red')
+    '\x1b[31mTest String\x1b[0m'
+
+    :param filename: file to determine color output for
+    :type filename: str
+    :return: filename with ANSII escape codes for color
+    :rtype: str
+    """
+    if os.path.isdir(filename):
+        return colored(filename, "blue")
+    elif os.path.islink(filename):
+        return colored(filename, "green")
+    else:
+        return filename
+
+
+# ========== Main Script ==========
+if __name__ == "__main__":
+    parser = argparse.ArgumentParser()
+    parser.add_argument(
+        "-d",
+        "--directories-only",
+        action="store_const",
+        const=["--type", "directory"],
+        dest="fd_extra_opts",
+        help="filter results to directories",
+    )
+    parser.add_argument(
+        "-e",
+        "--empty-only",
+        action="store_const",
+        const=["--type", "empty"],
+        dest="fd_extra_opts",
+        help="filter results to empty files and directories",
+    )
+    parser.add_argument(
+        "-E",
+        "--extension",
+        action="append",
+        dest="extensions",
+        help="file extension",
+        metavar="ext",
+    )
+    parser.add_argument(
+        "-f",
+        "--files-only",
+        action="store_const",
+        const=["--type", "file"],
+        dest="fd_extra_opts",
+        help="filter results to files",
+    )
+    parser.add_argument(
+        "-F",
+        "--force-directory-delete",
+        action="store_true",
+        help="do not ignore non-empty directories, delete anyways",
+    )
+    parser.add_argument(
+        "-I",
+        "--no-ignore-vcs",
+        action="store_const",
+        const="--no-ignore-vcs",
+        dest="fd_extra_opts",
+        help="do not ignore .gitignore",
+    )
+    parser.add_argument(
+        "-i",
+        "--no-ignore",
+        action="store_const",
+        const="--no-ignore",
+        dest="fd_extra_opts",
+        help="do not ignore .gitignore and .fdignore",
+    )
+    parser.add_argument(
+        "-l",
+        "--links-only",
+        action="store_const",
+        const=["--type", "symlink"],
+        dest="fd_extra_opts",
+        help="filter results to symlinks",
+    )
+    parser.add_argument("patterns", nargs="+", help="file matching patterns")
+
+    args = parser.parse_args()
+
+    if args.fd_extra_opts is not None:
+        FD_OPTS.extend(args.fd_extra_opts)
+    if args.extensions is not None:
+        for ext in args.extensions:
+            FD_OPTS.extend(["--extension", ext])
+
+    files = {}
+    for pattern in args.patterns:
+        cmd = [FD_BIN, *FD_OPTS, pattern]
+        files.update(
+            subprocess.run(cmd, capture_output=True, text=True).stdout.splitlines()
+        )
+    files = sorted(files)
+
+    if files == []:
+        print(f"No results found, exiting")
+        exit(E_NO_RESULTS)
+
+    # Pretty print all filenames
+    for index, filename in enumerate([color_file(f) for f in files], 1):
+        print(f"{index}. {filename}")
+    # Padding line
+    print()
+
+    try:
+        user_response = input("Would you like to delete these files? ")
+    except KeyboardInterrupt:
+        exit(E_INPUT_INTERRUPTED)
+
+    if re.match(USER_RESPONSE_YES, user_response) is None:
+        print("Operation cancelled")
+        exit(E_USER_RESPONSE_NO)
+
+    # Remove files first
+    for f in [fi for fi in files if os.path.isfile(fi)]:
+        os.remove(f)
+
+    # Check -f, --force-directory-delete option
+    rmdir_func = shutil.rmtree if args.force_directory_delete else os.rmdir
+
+    for d in filter(os.path.isdir, files):
+        try:
+            rmdir_func(d)
+        except OSError:
+            print(
+                f"{colored('Warning', 'yellow')}: {colored(d, 'blue')} is not empty, not deleting directory"
+            )
+
+    print(colored("\nDeletions complete", "green"))

zsh/completions/_ddusb

@@ -1,7 +1,6 @@
 #compdef ddusb
 
 # zsh completions for 'ddusb'
-# automatically generated with http://github.com/RobSis/zsh-completion-generator
 local arguments
 
 arguments=(

zsh/completions/_fedit

@@ -2,12 +2,13 @@
 local arguments
 
 arguments=(
-$argument_list
+  {-h,--help}'[show this help message and exit]'
-  {-h, --help}'[show this help message and exit]'
+  {-b,--boot}'[edit a file in /boot]'
-  {-b, --boot}'[edit a file in /boot]'
+  {-d,--dir}'[edit a file in a given directory]'
-  {-d, --dir}'[edit a file in a given directory]'
+  {-E,--etc}'[edit a file in /etc]'
-  {-E, --etc}'[edit a file in /etc]'
+  {-e,--editor}'[use a given editor]'
-  {-e, --editor}'[use a given editor]'
+  {-I,--no-ignore}'[do not respect  .(git|fd)ignore files]'
+  {-i,--no-ignore-vcs}'[do not respect .gitignore files]'
   '*:filename:_files'
 )
 

zsh/completions/_quickdel

@@ -4,11 +4,17 @@
 local arguments
 
 arguments=(
-  {-d,--directories-only}'[only delete directories]'
+  {-d,--directories-only}'[filter results to directories]'
+  {-e,--empty-only}'[filter results to empty files and directories]'
+  {-f,--files-only}'[filter results to files]'
+  {-F,--force-directory-delete}'[do not ignore non-empty directories, delete anyways]'
+  {-E,--extension}'[file extension]'
   {-h,--help}'[print this help page]'
   {-i,--no-ignore}'[do not ignore .gitignore and .fdignore]'
   {-I,--no-ignore-vcs}'[do not ignore .gitignore]'
+  {-l,--links-only}'[filter results to symlinks]'
   '*:filename:_files'
 )
 
+
 _arguments -s $arguments